Modernize build system #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed links in README and did some minor reformatting in there.
Moved notebooks and images to own dirs
Move missed image file
Also edited the instructions a little. Checked build.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1 -- will need to merge that first.
The goal here was to get rid of
setup.py, because it had conflicting metadata and you no longer need both it andpyproject.toml.Note. In order to build and install the project, you have two options:
pip install .orpip install -e .(editable, for using during development) -- you will probably do this most of the time.python -m buildwhich will create the wheel and the zip package for upload to PyPI.Any questions, let me know.