Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some models do not require a unique identifier (
id
property) from the perspective of a producer, however it is used internally to determine object equality. For example, it would make sense that a telemetry document from a sensor may simply not require a unique identifier:Originally I had enforced that the producer must generate a unique identifier before committing the model to the system state. However, this breaks encapsulation since the
id
is only used internally by myosin. I have changed the model parameters to optionally allow the producer to set a unique identifier which is useful for REST API models with database transactions. If unset theBaseModel
will generate a UUID which any module can access through the sameid
property.Resolutions