Remove the swap version pin to allow the newer version. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuazo
requested changes
Feb 17, 2018
metadata.rb
Outdated
| @@ -26,7 +26,7 @@ | |||
| Creates a swap file of the recommended size considering the system memory. | |||
| EOS | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '0.3.0' # WiP | |||
| version '0.3.1' # WiP | |||
There was a problem hiding this comment.
Please don't change bump the version. The version 0.3.0 is still unreleased.
metadata.rb
Outdated
| @@ -45,7 +45,7 @@ | |||
| supports 'suse' | |||
| supports 'ubuntu' | |||
|
|
|||
| depends 'swap', '~> 0.3' | |||
| depends 'swap' | |||
There was a problem hiding this comment.
Why not update the condition instead of removing it? Any reason? 😕
zuazo
added
Status: Pending Contributor Response
and removed
Status: Maintainer Review Needed
labels
daveallen
force-pushed
the
swap_unpin
branch
from
ac09f34
to
95d9fe2
Compare
|
Okay, just changed the version. |
zuazo
added
Status: Maintainer Review Needed
and removed
Status: Pending Contributor Response
labels
|
Can you merge the pull request so I can use the supermarket version in my cookbooks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version pinned had a bug that broke swap-tuning.