This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
Move the version number from setup.py to bitfield/__init__.py #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the runtime cost of importing pkg_resources, which is typically in the hundreds of milliseconds. It also fixes a problem where the version number was not being found at all, because the distribution name is django-bitfield, not bitfield. Fixes disqus#69. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Jul 18, 2018
See zulip#9953, zulip/django-bitfield#1. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Jul 18, 2018
See zulip#9953, zulip/django-bitfield#1. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This was referenced Jul 18, 2018
ljagielski2
pushed a commit
to ljagielski2/zulip
that referenced
this pull request
Aug 18, 2018
See zulip#9953, zulip/django-bitfield#1. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the runtime cost of importing
pkg_resources, which is typically in the hundreds of milliseconds. It also fixes a problem where the version number was not being found at all, because the distribution name isdjango-bitfield, notbitfield.Fixes disqus#69.