Cyclically go through domain objects

Fixes an issue where resetting the app data would cause the app to crash because of an increase in data-tab-id of the server tab element. Fix Travis errors Fix Travis errors Fix Travis errors
zulip · Jan 8, 2019 · b58c34e · b58c34e
1 parent dfeb1b7
commit b58c34e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/app/renderer/js/main.js b/app/renderer/js/main.js
@@ -159,25 +159,25 @@ class ServerManagerView {
 		const showSidebar = ConfigUtil.getConfigItem('showSidebar', true);
 		this.toggleSidebar(showSidebar);
 		// Allow dragging of server tabs and update the data-tab-id
-		const onEnd = (function onDragEnd(event) {
+		const onEnd = () => {
 			const newTabs = [];
 			const domains = [];
 			const tabElements = document.querySelectorAll('#tabs-container .tab');
 			tabElements.forEach((el, index) => {
-				const oldIndex = +Number(el.getAttribute('data-tab-id'));
+				const oldIndex = +Number(el.getAttribute('data-tab-id')) % tabElements.length;
 				el.setAttribute('data-tab-id', index.toString());
 				domains.push(DomainUtil.getDomain(oldIndex));
 				newTabs.push(this.tabs[oldIndex]);
 			});
-			for (let index = 0; index < domains.length; ++index) {
+			/*for (let index = 0; index < domains.length; ++index) {
 				DomainUtil.updateDomain(index, domains[index]);
 			}
 			this.tabs = newTabs;
 			ipcRenderer.send('update-menu', {
 				tabs: this.tabs,
 				activeTabIndex: this.activeTabIndex
-			});
-		}).bind(this);
+			});*/
+		};
 		this.$sortable = Sortable.create(this.$drag, {
 			dataIdAttr: 'data-sortable-id',
 			onEnd