Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streams to PerAccountStore, with a map keyed by stream ID #136

Closed
chrisbobbe opened this issue May 27, 2023 · 2 comments · Fixed by #139
Closed

Add streams to PerAccountStore, with a map keyed by stream ID #136

chrisbobbe opened this issue May 27, 2023 · 2 comments · Fixed by #139
Assignees
@gnprice
Labels
a-model Implementing our data model (PerAccountStore, etc.)
Milestone
Alpha

Comments

@chrisbobbe
Copy link
Collaborator

We should initialize this from the streams key in the initial snapshot (InitialSnapshot), and keep it updated in response to stream events.
@chrisbobbe chrisbobbe added the a-model Implementing our data model (PerAccountStore, etc.) label May 27, 2023
@chrisbobbe chrisbobbe added this to the Alpha milestone May 31, 2023
@chrisbobbe chrisbobbe assigned chrisbobbe and gnprice and unassigned chrisbobbe May 31, 2023
@chrisbobbe
Copy link
Collaborator Author

Assigning Greg because he mentioned having a local branch that accomplishes this.

@gnprice
Copy link
Member

gnprice commented May 31, 2023

My branch (which I'll send as a PR shortly) adds InitialSnapshot.streams, and adds a map on PerAccountStore, but doesn't add the event-handling to keep the map updated.

I think that's fine for the moment; it's how the subscriptions map already works. We can let #135 track the need to add event-handling to update this data.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue May 31, 2023
@gnprice
store: Add streams map
6d2bc64 
Fixes: zulip#136
@gnprice gnprice mentioned this issue May 31, 2023
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 1, 2023
@gnprice
store: Add streams map
6b8ecb3 
Fixes: zulip#136
chrisbobbe pushed a commit that referenced this issue Jun 1, 2023
@gnprice @chrisbobbe
store: Add streams map
9520c92 
Fixes: #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-model Implementing our data model (PerAccountStore, etc.)
Projects
Flutter app
Status: Done
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

Add streams to PerAccountStore gnprice/zulip-flutter
2 participants
@gnprice @chrisbobbe