Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open a message list in the middle of history, when requested #82

Open
gnprice opened this issue Apr 21, 2023 · 0 comments
Open

Open a message list in the middle of history, when requested #82

gnprice opened this issue Apr 21, 2023 · 0 comments
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone
Beta 3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented Apr 21, 2023 •
edited
Loading

When the user takes an action that should navigate to a particular "anchor" message (like through #73 internal links, #76 deep links, or a notification), we should take them straight to that message, rather than to the latest message or first unread message in the narrow.

This is a feature the zulip-mobile RN app lacks: zulip/zulip-mobile#3604 . (That's for internal links, but the app doesn't have it for notifications either — see narrowToNotification which passes no anchor to doNarrow — and doesn't have deep links.)

There are two parts to this:

  • Fetch the messages around the desired anchor, rather than around the latest message or the first unread.
  • Control the scroll position so that we show the desired anchor message.

This has a lot in common with:

This issue has fewer prerequisites technically than #80 — no need for #79 first. On the other hand it has more prerequisites before there's a UX context where it makes sense: it'd need either #73, #76, or notifications, all of which are more complex than #79.
@gnprice gnprice mentioned this issue Apr 21, 2023
Closed
@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label May 27, 2023
@gnprice gnprice added this to the Beta milestone Jun 14, 2023
gnprice added a commit that referenced this issue Jun 14, 2023
@gnprice
doc: Convert remaining TODOs from readme into GitHub issues
04deea2 
Filed #187, #188, and #190.

Other items already existed as #80, #82, #95, #122, and #123,
or were already complete (a compose box, and three ways of
attaching something to a message.)
@gnprice gnprice mentioned this issue Jul 12, 2023
Closed
@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@chrisbobbe chrisbobbe mentioned this issue Nov 2, 2023
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jan 30, 2024
@gnprice
msglist [nfc]: Let ScrollView count forward, and sliver handle reverse
fdb8fc2 
This means that the overall scroll view has AxisDirection.down
as the scroll direction, rather than AxisDirection.up, and the
SliverStickyHeader is passed GrowthDirection.reverse instead
of GrowthDirection.forward in order to get the same effect.

This makes the scrolling a little easier to think about when focused
on MessageList's code, because for example (as seen in this diff)
`scrollMetrics.extentBefore` now refers to the messages that are
older than the ones on screen, rather than those that are newer.

This also brings us closer to the setup we'll want for zulip#80 and zulip#82,
opening the message list at an anchor other than the end: the empty
placeholder sliver at the bottom will become the list of messages
after the starting anchor, while the sliver at the top will remain
the list of messages above the anchor.
@gnprice gnprice mentioned this issue Jan 30, 2024
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jan 30, 2024
@gnprice
msglist [nfc]: Let ScrollView count forward, and sliver handle reverse
9560245 
This means that the overall scroll view has AxisDirection.down
as the scroll direction, rather than AxisDirection.up, and the
SliverStickyHeader is passed GrowthDirection.reverse instead
of GrowthDirection.forward in order to get the same effect.

This makes the scrolling a little easier to think about when focused
on MessageList's code, because for example (as seen in this diff)
`scrollMetrics.extentBefore` now refers to the messages that are
older than the ones on screen, rather than those that are newer.

This also brings us closer to the setup we'll want for zulip#80 and zulip#82,
opening the message list at an anchor other than the end: the empty
placeholder sliver at the bottom will become the list of messages
after the starting anchor, while the sliver at the top will remain
the list of messages above the anchor.
chrisbobbe pushed a commit that referenced this issue Jan 30, 2024
@gnprice @chrisbobbe
msglist [nfc]: Let ScrollView count forward, and sliver handle reverse
bdac26f 
This means that the overall scroll view has AxisDirection.down
as the scroll direction, rather than AxisDirection.up, and the
SliverStickyHeader is passed GrowthDirection.reverse instead
of GrowthDirection.forward in order to get the same effect.

This makes the scrolling a little easier to think about when focused
on MessageList's code, because for example (as seen in this diff)
`scrollMetrics.extentBefore` now refers to the messages that are
older than the ones on screen, rather than those that are newer.

This also brings us closer to the setup we'll want for #80 and #82,
opening the message list at an anchor other than the end: the empty
placeholder sliver at the bottom will become the list of messages
after the starting anchor, while the sliver at the top will remain
the list of messages above the anchor.
@chrisbobbe chrisbobbe mentioned this issue Feb 26, 2024
Open
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
This was referenced May 16, 2024
Open
Closed
@chrisbobbe chrisbobbe mentioned this issue Jun 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: No status
Milestone
Beta 3: Summer 2024
Development

No branches or pull requests
1 participant
@gnprice