Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flutter and all packages to latest #621

Merged
merged 6 commits into from
Apr 6, 2024

Commits on Apr 6, 2024

  1. android: Bump minSdkVersion to 28, aka Android 9 Pie

    In 2023-09, just 2.2% of our zulip-mobile Android users were below
    this version, according to stats Greg posted:
      https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1648299
    
    So I think by now we can be comfortable making this the new minumum.
    
    I'm not sure if this is actually strictly required by some
    dependency upgrades we'll take later in this series of commits. But
    Android 9 is what the office Android device is on, and the core team
    doesn't have a physical device running a lower version. So we'll
    validate the upcoming dependency upgrades experimentally, by running
    on the office Android device. And with this bump to the threshold,
    we can leave it at that.
    
    Discussion:
      https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Java.20versions.3F/near/1775991
    chrisbobbe committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    400f1a5 View commit details
    Browse the repository at this point in the history
  2. deps: Update Flutter to latest main, 3.22.0-5.0.pre.22

    And update Flutter's supporting libraries to match.
    chrisbobbe committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    0b910af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    106e739 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    79fd015 View commit details
    Browse the repository at this point in the history
  5. deps: Upgrade packages to latest

    Done because it's the first step in our plan for zulip#612, the "Missing
    API declaration" warning from Apple.
    
    This is the result of `tools/upgrade pod-major`. No breaking changes
    requiring synchronous code changes were found.
    
    Changelogs:
      https://pub.dev/packages/device_info_plus/changelog
      https://pub.dev/packages/file_picker/changelog
      https://pub.dev/packages/flutter_local_notifications/changelog
      https://pub.dev/packages/package_info_plus/changelog
      https://pub.dev/packages/share_plus/changelog
      https://pub.dev/packages/pigeon/changelog
    
    All of these changelogs except `pigeon` mention adding "privacy
    info" or "privacy manifest" in the version we're taking here --
    exactly the kind of thing we want to see, with zulip#612 in mind. And
    `pigeon` shouldn't need one, as it's a dev dependency only, not part
    of the actual build.
    
    Related: zulip#612
    chrisbobbe committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    8df3064 View commit details
    Browse the repository at this point in the history
  6. ios: Proactively bump min iOS version to 14.0, matching zulip-mobile

    We could almost certainly bump it to 15, based on the last
    platform-version statistics Greg posted, and that was in 2023-09:
      https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1648327
    
    But there isn't specific code we want to write for iOS 15 features
    right now, so might as well leave that for later.
    
    In fact, I don't think there's a particularly strong need to bump it
    to 14, at least at the moment. But there's no reason it needs to lag
    behind zulip-mobile. And in case the lower threshold would be an
    obstacle later on, it's nice to have it cleared away proactively
    ahead of time.
    chrisbobbe committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a7ed31e View commit details
    Browse the repository at this point in the history