Upgrade Flutter and all packages to latest #621
Conversation
|
Thanks! All these changes look good. I won't have time to read those changelogs before heading out on vacation; but if you've read them and nothing jumps out at you, and given that it passes your manual testing, please go ahead and merge. I looked through all these changes other than reading the changelogs. Great! Yeah. And more concretely: it's a dev dependency only, so it's not part of the actual app build. |
|
Hmm, a CI failure: But when I run |
|
Ah, and CI is failing — looks like you just need to update the Pigeon-generated output. (And then I guess rerun the manual testing, unless the changes are trivial.) |
|
Huh odd. I guess one thing you can do to debug is to edit |
|
Alternatively, try making a meaningless edit to the Pigeon input file and rerunning Pigeon — wonder if this is a caching issue, like the one we've seen with other code generators (using build_runner). |
Aha, this seems like a useful clue from that output: -// Autogenerated from Pigeon (v17.2.0), do not edit directly.
+// Autogenerated from Pigeon (v18.0.0), do not edit directly. |
|
The issue seems to be that the old Pigeon 17 is running locally despite the upgrade in the headline commit taking it to Pigeon 18. The command Then I did something different: and thereafter, |
chrisbobbe
force-pushed
the
pr-deps-latest-2024-04-05
branch
from
4cecea5
to
0557f76
Compare
|
Anyway, revision pushed; |
|
And I've just redone manual tests for Android notifications. (The code did look NFC to me, but just for good measure.)
Cool; yep. Merging. |
chrisbobbe
force-pushed
the
pr-deps-latest-2024-04-05
branch
from
0557f76
to
81851d0
Compare
|
Filed #622 for the Pigeon version issue. |
In 2023-09, just 2.2% of our zulip-mobile Android users were below this version, according to stats Greg posted: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1648299 So I think by now we can be comfortable making this the new minumum. I'm not sure if this is actually strictly required by some dependency upgrades we'll take later in this series of commits. But Android 9 is what the office Android device is on, and the core team doesn't have a physical device running a lower version. So we'll validate the upcoming dependency upgrades experimentally, by running on the office Android device. And with this bump to the threshold, we can leave it at that. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Java.20versions.3F/near/1775991
And update Flutter's supporting libraries to match.
Done because it's the first step in our plan for zulip#612, the "Missing API declaration" warning from Apple. This is the result of `tools/upgrade pod-major`. No breaking changes requiring synchronous code changes were found. Changelogs: https://pub.dev/packages/device_info_plus/changelog https://pub.dev/packages/file_picker/changelog https://pub.dev/packages/flutter_local_notifications/changelog https://pub.dev/packages/package_info_plus/changelog https://pub.dev/packages/share_plus/changelog https://pub.dev/packages/pigeon/changelog All of these changelogs except `pigeon` mention adding "privacy info" or "privacy manifest" in the version we're taking here -- exactly the kind of thing we want to see, with zulip#612 in mind. And `pigeon` shouldn't need one, as it's a dev dependency only, not part of the actual build. Related: zulip#612
We could almost certainly bump it to 15, based on the last platform-version statistics Greg posted, and that was in 2023-09: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1648327 But there isn't specific code we want to write for iOS 15 features right now, so might as well leave that for later. In fact, I don't think there's a particularly strong need to bump it to 14, at least at the moment. But there's no reason it needs to lag behind zulip-mobile. And in case the lower threshold would be an obstacle later on, it's nice to have it cleared away proactively ahead of time.
chrisbobbe
force-pushed
the
pr-deps-latest-2024-04-05
branch
from
81851d0
to
a7ed31e
Compare
Done because it's the first step in our plan for #612, the "Missing API declaration" warning from Apple.
Changelogs for deps that are major-version upgraded:
https://pub.dev/packages/device_info_plus/changelog
https://pub.dev/packages/file_picker/changelog
https://pub.dev/packages/flutter_local_notifications/changelog
https://pub.dev/packages/package_info_plus/changelog
https://pub.dev/packages/share_plus/changelog
https://pub.dev/packages/pigeon/changelog
Manual tests done:
device_info_plusexercised and seems to work correctly (discussion)Related: #612