Upgrade dependencies, 2024-05 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
approved these changes
May 29, 2024
| @@ -1,5 +1,6 @@ | |||
| // Autogenerated from Pigeon (v18.0.0), do not edit directly. | |||
| // Autogenerated from Pigeon (v18.0.1), do not edit directly. | |||
There was a problem hiding this comment.
Interesting, it sounds like you didn't run into #622, or if you did, you found a workaround.
There was a problem hiding this comment.
I did, and I ended up running dart run pigeon which fixed it. (Just like you did at #621 (comment) .) So the commit message is a bit idealized; I'll clarify.
Done with: $ flutter pub upgrade pigeon $ dart run pigeon $ tools/check --all-files --fix pigeon The `dart run pigeon` step just ends up printing the command's CLI help... but first it causes the `pigeon` package's CLI binary to get rebuilt. So it serves as a workaround for zulip#622.
Done with: $ flutter pub upgrade json_serializable json_annotation $ tools/check --fix --all-files build_runner
Done with: $ flutter pub upgrade drift drift_dev $ tools/check --fix --all-files build_runner drift
This is the result of `tools/upgrade pod-major`. All of these are dev-only dependencies, so what you see is what you get. The only effect of the `pigeon` upgrade is the changes below (which are only in comments noting the version itself); and given that the `lints` and `flutter_lints` upgrades don't cause the analyzer to complain, there's nothing else they could do to break things. Looking at changelogs, the linter upgrades add and remove some lints to the list, and the Pigeon upgrade has a breaking change for Swift. Changelogs: https://pub.dev/packages/pigeon/changelog https://pub.dev/packages/lints/changelog https://pub.dev/packages/flutter_lints/changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit more involved than usual because it turns out several of our dependencies had releases recently that changed generated files. I might follow up by extending
tools/upgradeto automate those too, either now or next time it happens.We should also upgrade Flutter itself, but it's getting to the end of the day so sending what I have.