Skip to content

Commit

Permalink
webview, css: Fix emoji in bold gets rendered twice.
Browse files Browse the repository at this point in the history
Use `overflow: hidden` in the emoji `span` tag (webapp also uses it).
html for emoji inside bold formatting is like:

```
<strong>
	<span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">
		<span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">
			:tada:
		</span>
	</span>
	some text
</strong>
```

Thus adding `overflow: hidden;` hides the overflow i.e extra emoji.

Fixes: #3321
  • Loading branch information
jainkuniya committed Feb 15, 2019
1 parent 595b41b commit 8930bd6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/webview/css/css.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ blockquote {
white-space: nowrap;
color: transparent;
vertical-align: text-top;
overflow: hidden;
}
.emoji:before {
color: white;
Expand Down

0 comments on commit 8930bd6

Please sign in to comment.