Skip to content

Commit

Permalink
ios: Add boilerplate about APIs we don't, in fact, use.
Browse files Browse the repository at this point in the history
This follows the suggestion of the react-native-unimodules authors:
  https://github.com/unimodules/react-native-unimodules/blob/14f192c1f/README.md

These are needed because (a) some of the code in react-native-unimodules
apparently refers to these APIs, and (b) for Calendars, Contacts, and
Microphone in particular, Apple refuses to allow an app to be uploaded
if it has code referring to these APIs and doesn't have a purpose string.
That means this blocks uploading a release for iOS.

We don't actually ever *invoke* any of that code (barring some very
surprising bug in react-native-unimodules.)  As a result these strings
will never actually be shown to the user.  A better solution would be
to find a way to leave that code out of the build, so that the Apple
robot doesn't mistakenly think we might use it and nag us for these
strings.  But this will do for a minimal fix.
  • Loading branch information
gnprice committed May 7, 2020
1 parent 2493f3d commit c8d0c8d
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion ios/ZulipMobile/Info.plist
Expand Up @@ -48,14 +48,28 @@
</dict>
</dict>
</dict>
<key>NSCalendarsUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to access your calendar</string>
<key>NSCameraUsageDescription</key>
<string>Take a photo and upload it to a Zulip realm</string>
<key>NSContactsUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to access your contacts</string>
<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to use your location</string>
<key>NSLocationAlwaysUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to use your location</string>
<key>NSLocationWhenInUseUsageDescription</key>
<string></string>
<string>Allow $(PRODUCT_NAME) to use your location</string>
<key>NSMicrophoneUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to access your microphone</string>
<key>NSMotionUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to access your device's accelerometer</string>
<key>NSPhotoLibraryAddUsageDescription</key>
<string>Download photos from Zulip realm</string>
<key>NSPhotoLibraryUsageDescription</key>
<string>Upload photos to a Zulip realm</string>
<key>NSRemindersUsageDescription</key>
<string>Allow $(PRODUCT_NAME) to access your reminders</string>
<key>UIAppFonts</key>
<array>
<string>Entypo.ttf</string>
Expand Down

0 comments on commit c8d0c8d

Please sign in to comment.