-
-
Notifications
You must be signed in to change notification settings - Fork 639
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SmartUrlInput: Remove not-so-helpful "smart"ness
And just use an ordinary controlled TextInput, always stretched to full width, and never just 1px. The major reason for this is to help with #5228 (can't paste org URL): native copy-paste is activated by long-pressing in the input element itself. But long-pressing is really hard when the element is only 1px wide! No need to autocomplete with "zulipchat.com", so as not to annoy self-hosted users, as discussed. It does seem helpful to prepopulate with "https://" for the sake of users who aren't copy-pasting. With that "https://" prepopulating in mind, we'll improve this experience further, along the lines of what Alya says: > One would have to play with pasting behavior to make sure > something reasonable happens if you are trying to paste in a whole > URL, including the https part. That'll come later in this series. See discussion at https://chat.zulip.org/#narrow/stream/48-mobile/topic/can't.20paste.20org.20URL/near/1327170 Fixes-partly: #5228
- Loading branch information
1 parent
77d578f
commit f3d37ee
Showing
1 changed file
with
10 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters