Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace issue with few messages in a narrow #165

Closed
neerajwahi opened this issue Jan 3, 2017 · 9 comments
Closed

Whitespace issue with few messages in a narrow #165

neerajwahi opened this issue Jan 3, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@neerajwahi
Copy link
Member

Example:
screenshot 2017-01-02 15 30 56

@neerajwahi neerajwahi added the bug label Jan 3, 2017
@timabbott timabbott modified the milestone: M4 Jan 3, 2017
@borisyankov
Copy link
Contributor

Elaborate.

@timabbott
Copy link
Sponsor Member

timabbott commented Jan 4, 2017

The issue here is that we should display the message at the top of the screen and have whitespace below, similar to how the Zulip webapp works. That way, when new messages come in, it doesn't require unnecessary scrolling down (in addition to being more consistent).

@borisyankov
Copy link
Contributor

That is intentional. It works like that in all major competitors:

  • Slack
  • Facebook Messenger
  • Google Hangouts

@timabbott
Copy link
Sponsor Member

Plenty of other chat tools work this way (with short feeds placed at the top rather than the bottom), e.g. the default Android text messaging app. But the important thing for Zulip is that we place much more emphasis than other products on actually tracking what you've read (as opposed to just marking entire views as read as soon as you look at them), and that model impacts what the best UI is for certain things.

It also just looks weird with the heading showing what you're looking at (which is at the top of the screen and not repeated) so far from the actual message.

The bottom whitespace is I think also something we'll want even if there is significant message history, so that after you scroll to the bottom, the next message that comes in is on-screen without scrolling your view.

@borisyankov
Copy link
Contributor

borisyankov commented Jan 4, 2017

This is how the default messaging app on Android looks like:
https://lh3.googleusercontent.com/Du0zmgVl2wURALZHc6U2OdgCx5595cYsjNxLAVUI7XN5ZPDnFZ3SYqA2YVqj4dEphO8HjmhZS0s2HpuY6P9BX8ShvXEQ3wZ40i7epBOn8cdv_oMKU5kqmxI-6QQ5elKTy7bW7rC7ZJk9cxha4hs9Gtvetu35aw7ug1dyRWRkaRJYlV17Jdnse6QIuhWC07KmVMzu-bz-TJdbRe-NH_9azaQ0uU7oGnWQTqXNjyEODgp5jc5usiT0bcu0NjZ5TjRKfCWOmNhBHy6skCBTcO9DRpQfIaWHtGAy4HfcEAt1X91A65HFemGaNEyTlly1ZQoCGCZ7dohJQRMejzXo9IRwL4vGg7oQDXcukrLSRYWy09_NyxwekIP4A0u2-BegWWx55KU-HbxHWRw29r_bgUnYUeDIVkZJpGJNSBKM2Mi6vRk7tV69IordJn-8o4WiTLDSdwTt8te-iOi-184QkYQS2HNVwi5hHX33lyGjfeCNBp7mHgE1eQkif6Yl-XhF3a2a7J6CmuegNQsJkSfdjxORWWhUM_-nzByHVGshJ2WNwWrH2SEsEhhOp3Mm3ScdXg2-oXur7gaNSxSG2-PudHwHuC7Xk4qydHUoMWNZ75S1-pvGlI8mOE2lFSHbMCLSU9gjPueloW-mTqamcaRELaNQDUnKNZWdvcxv7ieJqcl4ME0=w768-h1362-no

@borisyankov
Copy link
Contributor

The sticking to bottom is a completely separate issue that has to be fixed either way.

@timabbott
Copy link
Sponsor Member

Interesting, I seem to have a totally different one.

@borisyankov borisyankov self-assigned this Jan 4, 2017
@borisyankov
Copy link
Contributor

What brand of phone do you have?
I am with Nexus 6P - so this is the actual default messaging app coming from Google.
If you have Samsung/Sony etc. they tend to have their own apps.

@timabbott
Copy link
Sponsor Member

Samsung, this is probably their app.

Regardless, I think for Zulip in particular, because of the potential for multiple layers of headings (if you're narrowed to a stream, for example), it's probably best to have results appear at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants