Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor updateExistingStream: Reduce api calls on changing stream details. #3222

Closed
jainkuniya opened this issue Dec 18, 2018 · 1 comment
Closed

refactor updateExistingStream: Reduce api calls on changing stream details. #3222

jainkuniya opened this issue Dec 18, 2018 · 1 comment

Comments

@jainkuniya
Copy link
Member

Currently if user changes stream name and description, then we are making two API calls. On the other hand streams API endpoint is generic and can handle multiple properties at the same time. So redactor updateExistingStream method, so that in such cases only one request is send to server.

https://chat.zulip.org/#narrow/stream/3-backend/topic/api.20.2Fstreams.2F.24.7Bid.7D

@zulipbot claim
@jainkuniya jainkuniya changed the title refactor updateExistingStream: Reduce api calls on changing stream updation. refactor updateExistingStream: Reduce api calls on changing stream details. Dec 18, 2018
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Dec 18, 2018
@jainkuniya
updateExistingStream: Reduce api calls on changing stream details.
6e77c13 
Before inidividual api calls were made for each stream property which
is changed. But on server, this api is capable of handeling multiple
propery at a time. So just call api once with all the properties which
are changed.

Fixes: zulip#3222
@jainkuniya jainkuniya mentioned this issue Dec 18, 2018
Closed
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jan 1, 2019
@jainkuniya
updateExistingStream: Reduce api calls on changing stream details.
3f43ccb 
Before inidividual api calls were made for each stream property which
is changed. But on server, this api is capable of handeling multiple
propery at a time. So just call api once with all the properties which
are changed.

Fixes: zulip#3222
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jan 19, 2019
@jainkuniya
updateExistingStream: Reduce api calls on changing stream details.
16ef27d 
Before inidividual api calls were made for each stream property which
is changed. But on server, this api is capable of handeling multiple
propery at a time. So just call api once with all the properties which
are changed.

Fixes: zulip#3222
jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jan 19, 2019
@jainkuniya
updateExistingStream: Reduce api calls on changing stream details.
fed1791 
Before inidividual api calls were made for each stream property which
is changed. But on server, this api is capable of handeling multiple
propery at a time. So just call api once with all the properties which
are changed.

Fixes: zulip#3222
@gnprice
Copy link
Member

gnprice commented Jun 17, 2022

This was fixed by be12766 / #5341 .

@gnprice gnprice closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updateExistingStream: Reduce api calls on changing stream details. jainkuniya/zulip-mobile
2 participants
@gnprice @jainkuniya