Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanently unsendable messages are shown with spinners #3731

Open
rk-for-zulip opened this issue Dec 18, 2019 · 4 comments
Open

Permanently unsendable messages are shown with spinners #3731

rk-for-zulip opened this issue Dec 18, 2019 · 4 comments
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending

Comments

@rk-for-zulip
Copy link
Contributor

rk-for-zulip commented Dec 18, 2019 •
edited

If sending a message fails with a 4xx error (indicating that retrying won't help), the message still appears in the message list with a spinner, rather than some form of failure UI.
@rk-for-zulip rk-for-zulip mentioned this issue Dec 30, 2019
Closed
@rk-for-zulip
Copy link
Contributor Author

One reproduction method here (until #3743 is fixed) is to send a message with an empty or whitespace-only topic.

@gnprice gnprice added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Dec 31, 2019
@gnprice gnprice mentioned this issue Dec 31, 2019
Closed
@rk-for-zulip
Copy link
Contributor Author

From offline brainstorming: perhaps there should be an optional httpResponse field in Outbox. Items with 4xx codes should be displayed as an ❌; other messages get the spinner.

We could also give httpResponse a special non-numeric "too old to send" value (see discussion on #3734) and retain messages that would have been dropped due to age, instead displaying them with an ❌ as well.

@rk-for-zulip rk-for-zulip mentioned this issue Jan 8, 2020
Closed
@gnprice
Copy link
Member

gnprice commented Jan 8, 2020

With the potential feature described in zulip/zulip#13626, this case may start arising more often.

@gnprice gnprice mentioned this issue Jan 21, 2020
Open
@gnprice gnprice mentioned this issue Feb 7, 2020
Open
@chrisbobbe
Copy link
Contributor

We've had another report of this, at #4033 (comment).

@chrisbobbe chrisbobbe mentioned this issue Apr 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnprice @chrisbobbe @rk-for-zulip