-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsendable messages have frozen spinners, on old Chrome #3730
Comments
This is fine in a modern Webview; per MDN it should only fail on Chrome <43, where the On the other hand, the |
The `animation` property doesn't appear to have been available without this prefix until Chrome 43, and we presently try to support as far back as Chrome 37. Fixes zulip#3730.
Huh, is this limited to unsendable messages? Or does it apply to all messages -- so e.g. if you're offline or have a slow connection, just enough to observe the spinner for more than a moment, you see the same effect? I see also #3731 which is about "permanently unsendable" messages; is that the same set of messages? |
Ah I see, but also this is only on Chrome <43. Copying what I just wrote on the PR #3735 (maybe I should have made the detailed comment here in the first place; oh well): Hmm, this is quite a fair bit of duplication: 23 lines across 8 places in the file. [Which is a perfectly reasonable way of making the fix; it's just the nature of the fix.] Here's what we say (in
I think the complexity of this fix falls well above the "trivial" threshold, in terms of its maintenance cost for ongoing changes to our CSS styles. Happily the issue is also fairly minor: it doesn't affect the actual functionality, and most users will rarely to never see it at all. So I think it's the kind of "graceful degradation" I'd be OK with at any Chrome version below 58, when the fix isn't trivial. Thanks for looking into this! I think based on the information collected, the best path is to close the PR and issue (as WONTFIX), and turn attention to other bugs and features. |
Unsendable messages appear in the message list with a frozen spinner, as shown below.
(This is a reprise, but apparently not a duplicate, of #1546.)
The text was updated successfully, but these errors were encountered: