Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colorHashFromString is almost nonfunctional #3985

Closed
rk-for-zulip opened this issue Mar 20, 2020 · 1 comment · Fixed by #3991
Closed

colorHashFromString is almost nonfunctional #3985

rk-for-zulip opened this issue Mar 20, 2020 · 1 comment · Fixed by #3991
Labels
good first issue

Comments

@rk-for-zulip
Copy link
Contributor

colorHashFromString:

  • ignores all characters in the string except the second;
  • returns #NaN on strings of length zero or one;
  • returns #NaN on very long strings;
  • cannot return any color with no red component; and
  • cannot return #ffffff.
@Maskedman99
Copy link
Contributor

@zulipbot claim

Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 21, 2020
@Maskedman99
group-pm: fix colorHashFromString
e43e3be 
colorHashFromString() now considers all charecters in the string
it can also now return colors with red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
@Maskedman99 Maskedman99 mentioned this issue Mar 21, 2020
Merged
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 25, 2020
@Maskedman99
group-pm: fix colorHashFromString
adef1b3 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 25, 2020
@Maskedman99
group-pm: fix colorHashFromString
c135d02 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 25, 2020
@Maskedman99
group-pm: fix colorHashFromString
e2359b2 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 25, 2020
@Maskedman99
group-pm: fix colorHashFromString
eb07b9c 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 25, 2020
@Maskedman99
group-pm: fix colorHashFromString
63bc582 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985

group-pm: fix colorHashFromString

colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 27, 2020
@Maskedman99
group-pm: fix colorHashFromString
4276aa1 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Mar 27, 2020
@Maskedman99
group-pm: fix colorHashFromString
5f89eb4 
colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: zulip#3985
@chrisbobbe chrisbobbe mentioned this issue Apr 13, 2020
Closed
rk-for-zulip pushed a commit to Maskedman99/zulip-mobile that referenced this issue Apr 13, 2020
@Maskedman99 @rk-for-zulip
group-pm: fix colorHashFromString
fc00fab 
colorHashFromString() now considers all characters in the string. It
can also now return colors with no red component in it. Also fixed the
cases where the function returned #NaN for very long or very short
strings.

[ray: Minor copyedits to commit message.]

Fixes: zulip#3985
rk-for-zulip pushed a commit to Maskedman99/zulip-mobile that referenced this issue Apr 13, 2020
@Maskedman99 @rk-for-zulip
group-pm: fix colorHashFromString
b08a014 
colorHashFromString() now considers all characters in the string. It
can also now return colors with no red component in it.

Also fixed the cases where the function returned #NaN for very long or
very short strings.

[ray: Minor copyedits to commit message.]

Fixes: zulip#3985
rk-for-zulip pushed a commit that referenced this issue Apr 13, 2020
@Maskedman99 @rk-for-zulip
group-pm: fix colorHashFromString
9161e47 
colorHashFromString() now considers all characters in the string. It
can also now return colors with no red component in it.

Also fixed the cases where the function returned #NaN for very long or
very short strings.

[ray: Minor copyedits to commit message.]

Fixes: #3985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

group-pm: fix colorHashFromString Maskedman99/zulip-mobile
2 participants
@Maskedman99 @rk-for-zulip