Add and enable @react-native-community/eslint-config.

[chrisbobbe]

This is included in the RN upgrade guide for v0.59.10 to v0.60.0.

Surprisingly, this didn't flag any errors in existing code. I confirmed that it was indeed activated by making an example that didn't get flagged before, but newly does. (A no-global-assign on attempting to reassign __fbBatchedBridgeConfig; see this.)

Here's the output of

$ node_modules/.bin/eslint --print-config .

with and without @react-native-community/eslint-config enabled:

printed-config-with-rnc.txt
printed-config-before.txt

One annoying bit is that one of its devDependencies has typescript as a peerDependency, so I get this:

warning "@react-native-community/eslint-config > @typescript-eslint/eslint-plugin > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

See also discussion.

[rk-for-zulip]

printed-config-before.txt
printed-config-with-rnc.txt

JSON diff:

 {
   globals: {
+    __fbBatchedBridgeConfig: false
-    clearImmediate: false
+    clearImmediate: true
-    exports: true
+    exports: false
-    setImmediate: false
+    setImmediate: true
-    Map: false
+    Map: true
-    Promise: false
+    Promise: true
-    Set: false
+    Set: true
-    requestAnimationFrame: false
+    requestAnimationFrame: true
-    requestIdleCallback: false
+    requestIdleCallback: true
   }
   rules: {
+    no-reserved-keys: 0
+    eslint-comments/no-aggregating-enable: 1
+    eslint-comments/no-unlimited-disable: 1
+    eslint-comments/no-unused-disable: 1
+    eslint-comments/no-unused-enable: 1
+    prettier/prettier: 2
+    space-in-brackets: 0
+    react/wrap-multilines: 0
+    react-hooks/rules-of-hooks: "error"
+    react-hooks/exhaustive-deps: "error"
+    react-native/no-inline-styles: 1
   }
   plugins: [
+    "eslint-comments"
+    "prettier"
+    "react"
+    "react-hooks"
+    "react-native"
+    "jest"
     "import"
-    "react"
     "jsx-a11y"
-    "jest"
     "flowtype"
   ]
   extends: [
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/best-practices.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/errors.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/node.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/style.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/variables.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/es6.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/imports.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/index.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb-base/rules/strict.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb/rules/react.js"
     "/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-config-airbnb/rules/react-a11y.js"
+    "@react-native-community"
     "airbnb"
     "plugin:jest/recommended"
     "./tools/formatting.eslintrc.yaml"
   ]
 }