Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide user emails in message reaction list according to email_address_visibility setting. #4188

Closed
sahil839 opened this issue Jul 10, 2020 · 1 comment
Closed

Hide user emails in message reaction list according to email_address_visibility setting. #4188

sahil839 opened this issue Jul 10, 2020 · 1 comment
Assignees
@agrawal-d
Labels
good first issue help wanted

Comments

@sahil839
Copy link

Email of users in the message rection list (which is opened by long-press on an existing reaction or by clicking on "See who reacted" from message action sheet) should be hidden when the original email is not visible to the user according to the email_address_visibility settings of the organization.

There is no use of showing the emails generated by user-id (of the form user1888@example.com), as it does not provide any information about the user.
@gnprice
Copy link
Member

gnprice commented Jul 10, 2020

Thanks @sahil839 !

In fact I think the best thing to do is to go farther than that: we should just leave out the email addresses on this screen unconditionally. Even when real email addresses are available, in this context they feel mostly like clutter.

The code that implements this screen is in src/reactions/MessageReactionList.js.

agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 13, 2020
@agrawal-d
message reaction list: Hide emails from user list.
ce0f0e1 
Removes user emails from the user list in the message reactions
screen because in this context, the emails mostly feel like
clutter.

As a side effect of this change, we no longer have to worry about
the server 'email_address_visibility' setting.

Fixes: zulip#4188.
@agrawal-d agrawal-d mentioned this issue Jul 13, 2020
Closed
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 13, 2020
@agrawal-d
message reaction list: Hide emails from user list.
9e303e0 
Removes user emails from the user list in the message reactions
screen because in this context, the emails mostly feel like
clutter.

As a side effect of this change, we no longer have to worry about
the server 'email_address_visibility' setting for this screen.

Fixes: zulip#4188.
@agrawal-d agrawal-d self-assigned this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrawal-d agrawal-d

Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

message reaction list: Hide emails from user list. agrawal-d/zulip-mobile
3 participants
@gnprice @agrawal-d @sahil839