Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "add reaction" button when there are already reactions on a message #4578

Open
WesleyAC opened this issue Mar 31, 2021 · 2 comments · May be fixed by #4594
Open

Show "add reaction" button when there are already reactions on a message #4578

WesleyAC opened this issue Mar 31, 2021 · 2 comments · May be fixed by #4594
Assignees
@Gautam-Arora24
Labels
a-emoji a-message list

Comments

@WesleyAC
Copy link
Contributor

Accessing the reaction menu can be confusing. We should offer a simple way to add a reaction when there are already reactions on a message:

0000-recent

(that's a screenshot from the webapp, something similar would be good in mobile)
@Gautam-Arora24
Copy link
Contributor

Gautam-Arora24 commented Mar 31, 2021 •
edited
Loading

@WesleyAC I would like to work on this issue.

@WesleyAC
Copy link
Contributor Author

Great! Exited to see this implemented :)

Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 3, 2021
@Gautam-Arora24
feat: Add an "add reaction button" when there are already reactions.
dacfd9a 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Create a type in "handleOutboundEvents" called "WebViewOutboundNavigate-
ToEmojiPicker" which helps to navigate to the emoji picker screen.

Add a check in "js.js" to call sendMessage when the target is "add-emoji-
button".

Ran "tools/generate-webview-js".

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
@Gautam-Arora24 Gautam-Arora24 linked a pull request Apr 3, 2021 that will close this issue
Open
Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 3, 2021
@Gautam-Arora24
feat: Add an "add reaction button" when there are already reactions.
291fe5e 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Create a type in "handleOutboundEvents" called "WebViewOutboundNavigate-
ToEmojiPicker" which helps to navigate to the emoji picker screen.

Add a check in "js.js" to call sendMessage when the target is "add-emoji-
button".

Ran "tools/generate-webview-js".

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 3, 2021
@Gautam-Arora24
webview: Add an "add reaction button" when there are already reactions.
7162c81 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 3, 2021
@Gautam-Arora24
webview: Add an "add reaction button" when there are already reactions.
2cc944f 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 3, 2021
@Gautam-Arora24
webview: Add an "add reaction button" when there are already reactions.
d8ae1f5 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
Gautam-Arora24 added a commit to Gautam-Arora24/zulip-mobile that referenced this issue Apr 6, 2021
@Gautam-Arora24
webview: Add an "add reaction button" when there are already reactions.
be128a9 
Add an "addReactionButtonAsHtml" in "messagesAsHtml" file which
provides the html to "messageBody" when there is already a
reaction in message.

Discussion of this in CZO [1].

[1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/Add.20Emoji.20Reaction.20Button

Fixes: zulip#4578
@gnprice gnprice mentioned this issue Nov 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gautam-Arora24 Gautam-Arora24

Labels
a-emoji a-message list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webview: Add an "add reaction button" when there are already reactions. Gautam-Arora24/zulip-mobile
3 participants
@gnprice @WesleyAC @Gautam-Arora24