Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic autocomplete missing part of touch target on iOS #5486

Closed
namse opened this issue Sep 13, 2022 · 6 comments · Fixed by #5682
Closed

Topic autocomplete missing part of touch target on iOS #5486

namse opened this issue Sep 13, 2022 · 6 comments · Fixed by #5682
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-iOS P1 high-priority

Comments

@namse
Copy link

namse commented Sep 13, 2022

Hi. Very recently when I tab the topic, it just ignores my input.

Upload.from.GitHub.for.iOS.MOV

I'm not sure why it happened.

@namse
Copy link
Author

namse commented Sep 13, 2022

I found that it only happened when I click left side of topics. I guess maybe resolved mark area makes some trouble.
image

@gnprice
Copy link
Member

gnprice commented Sep 27, 2022

Thanks @namse for the report!

I reproduce the issue. Specifically:

  • I see this on iOS (an iPhone 7 running iOS 15.6.1), but not on Android (a Pixel 4 running Android 12.)
  • The symptom is: when I try to select a topic from that autocomplete popup by tapping somewhere near its left edge -- in about the region indicated by the red box in your comment -- it doesn't work. Instead, it behaves as if I'd tapped outside the popup entirely, to dismiss the whole compose box.
  • On the other hand, if I tap anywhere else in the popup, it works fine -- the topic I tapped on gets selected.

I think the cause is not likely to be related to the resolved-topic checkmark. The symptom seems to be the same on topics that don't have that, and even when none of the topics in the list have it.

@gnprice gnprice added a-iOS a-compose/send Compose box, autocomplete, camera/upload, outbox, sending labels Sep 27, 2022
@gnprice gnprice changed the title Selecting topic doesn't work well Topic autocomplete missing part of touch target on iOS Sep 27, 2022
@gnprice
Copy link
Member

gnprice commented Sep 27, 2022

OK, and with some further testing:

  • I reproduce the issue on v27.191, the latest.
  • I don't reproduce the issue on v27.190, the previous version.

We sent v27.191 to all users on 2022-09-08, a few days before this issue was filed. So that fits very neatly with the mention of it happening "very recently".

@chrisbobbe would you take a look at debugging this? I think the next step is to bisect to find where the regression happened (or if you have a guess as to what caused the issue, then to check that guess directly.)

@chrisbobbe
Copy link
Contributor

Thanks for the report and video/screenshot, @namse, and thanks Greg for the investigation!

A git rebase has led me to 3edc37a as the offending commit; I plan to investigate soon.

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Sep 28, 2022

It appears that the react-native-gesture-handler upgrade in that commit was a factor, by changing React Navigation's behavior so that it closes the keyboard for the swipe-right-to-go-back gesture at the moment you press the screen, instead of when you actually start swiping.

I expect a fix in @react-navigation/stack 6.1.0, from commit react-navigation/react-navigation@5a19877. I did a quick manual cherry-pick of that commit (it's a one-line change) in node_modules at main and the symptom resolved.

Greg, do we think we could take that @react-navigation/stack 6.1.0 upgrade soon, or should we look at other options, like examining the reason for the gesture-handler upgrade for a possible revert, etc.?

@gnprice
Copy link
Member

gnprice commented Dec 8, 2022

We just had another report of this issue.

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Mar 13, 2023
(Much like we did for @react-navigation/bottom-tabs in c0b17bd.)

To get chrisbobbe/react-navigation@a588dcee9, which I've published
to NPM in @zulip/react-navigation-stack@5.14.10-0.zulip.1.

It cherry-picks react-navigation/react-navigation@5a1987708, which
fixes zulip#5486, as noted there:
  zulip#5486 (comment)

So this fix will become unnecessary when we're on React Navigation
6; that's issue zulip#4936.

Tested the bugfix on my iPhone 13 Pro running iOS 16.1, with and
without "Debug with Chrome". The bug was fixed, and back navigation
worked as expected, both with the swipe gesture and the back button.

Fixes: zulip#5486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-iOS P1 high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants