Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote-and-reply should use new /dm/… link format (instead of /pm-with/…) #5710

Closed
chrisbobbe opened this issue Apr 1, 2023 · 1 comment · Fixed by #5722
Closed

Quote-and-reply should use new /dm/… link format (instead of /pm-with/…) #5710

chrisbobbe opened this issue Apr 1, 2023 · 1 comment · Fixed by #5722
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Apr 1, 2023 •
edited by gnprice
Loading

In #5704 (for issue #5692), we started supporting links with the new format: when the user taps such a link, we know how to interpret it.

Clients will probably support the old format indefinitely, but it'd be good to switch to generating the new format in realms where the web app and other clients will also be expected to handle it. We'll recognize that condition by looking at the server's feature level.

Once the web app merges support for it and a new server feature level is made, we'll know which feature level to use for that condition, and so this will be ripe to work on. The umbrella issue for server and web is zulip/zulip#24806.
@chrisbobbe chrisbobbe added P1 high-priority blocked on other work To come back to after another related PR, or some other task. server release goal Things we should try to coordinate with a major Zulip Server release. labels Apr 1, 2023
@chrisbobbe chrisbobbe mentioned this issue Apr 1, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 25, 2023
@chrisbobbe
compose: Use new /dm/… link format in quote-and-reply, for recent ser…
7cbbcb7 
…vers

Fixes: zulip#5710
@chrisbobbe chrisbobbe mentioned this issue Apr 25, 2023
Merged
@chrisbobbe chrisbobbe removed the blocked on other work To come back to after another related PR, or some other task. label Apr 25, 2023
@chrisbobbe
Copy link
Contributor Author

With zulip/zulip#25003 in, this is now unblocked! Sent #5722 for it.

@chrisbobbe chrisbobbe added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.
Projects
No open projects
7.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compose: Use new /dm/… link format in quote-and-reply, for recent servers chrisbobbe/zulip-mobile
1 participant
@chrisbobbe