Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support followed topics in muted streams #5769

Closed
alya opened this issue Sep 28, 2023 · 0 comments · Fixed by #5774
Closed

Support followed topics in muted streams #5769

alya opened this issue Sep 28, 2023 · 0 comments · Fixed by #5774
Assignees
@gnprice
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Sep 28, 2023

In zulip/zulip#25673, we are adding the ability to follow topics. Followed topics should never be treated as muted, even if they are in a muted stream.
@alya alya added P1 high-priority webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Sep 28, 2023
gnprice added a commit to gnprice/zulip-mobile that referenced this issue Oct 4, 2023
@gnprice
api: Add "followed" user-topic state, as synonym of "unmuted"
3ca4ee1 
In all the places we currently consult the user's visibility policy
for a topic, treating "followed" as "unmuted" will give it the most
accurate behavior from among what we currently implement.

In particular this makes it so that when the stream is muted, the
topic will correctly be treated as not muted.

There's still more we could do to fully implement this feature:
notably, surface in the UI what the current state is, and give the
option to set a topic to followed.  But this is an important start.

Fixes: zulip#5769
@gnprice gnprice mentioned this issue Oct 4, 2023
Merged
@gnprice gnprice self-assigned this Oct 4, 2023
chrisbobbe pushed a commit that referenced this issue Oct 5, 2023
@gnprice @chrisbobbe
api: Add "followed" user-topic state, as synonym of "unmuted"
36f4466 
In all the places we currently consult the user's visibility policy
for a topic, treating "followed" as "unmuted" will give it the most
accurate behavior from among what we currently implement.

In particular this makes it so that when the stream is muted, the
topic will correctly be treated as not muted.

There's still more we could do to fully implement this feature:
notably, surface in the UI what the current state is, and give the
option to set a topic to followed.  But this is an important start.

Fixes: #5769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
No open projects
Zulip Server 8.0 priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "followed" user-topic state, as synonym of "unmuted" gnprice/zulip-mobile
2 participants
@gnprice @alya