Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse topic permalinks #5866

Closed
gnprice opened this issue May 16, 2024 · 0 comments · Fixed by #5868
Closed

Parse topic permalinks #5866

gnprice opened this issue May 16, 2024 · 0 comments · Fixed by #5868
Labels
a-message list P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.

Comments

@gnprice
Copy link
Member

gnprice commented May 16, 2024

When parsing an internal link, we should handle the upcoming "topic permalink" feature:

In the current draft, these look like /with/NNNN, with a message ID.

Currently the app doesn't interpret the "anchor" meaning of /near/ links at all (that's #3604) — we already effectively give /near/ links exactly the meaning that the upcoming /with/ links will have. So to handle the new links, we just need to parse them and then handle them the way we already handle /near/ links.
@gnprice gnprice added a-message list P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. labels May 16, 2024
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 3, 2024
@chrisbobbe
msglist: Handle topic permalinks (/with/<id>) just as we do /near/ links
9faa84b 
Explanation in a comment, which quotes Greg in zulip#5866.

Fixes: zulip#5866
@chrisbobbe chrisbobbe mentioned this issue Jun 3, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 10, 2024
@chrisbobbe
internalLinks: Relax narrow parsing, toward accepting dm links with /…
de473b0 
…with/

For this legacy codebase, we plan to treat the new /with/ links the
same as /near/ links; see zulip#5866.

This change makes getNarrowFromNarrowLink's handling of DM links
more parallel with its handling of topic links; now, neither one
will reject /with/ links. On Greg's suggestion:
  zulip#5868 (review)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 10, 2024
@chrisbobbe
msglist: Handle topic permalinks (/with/<id>) just as we do /near/ links
c752b48 
Explanation in a comment, which quotes Greg in zulip#5866.

Fixes: zulip#5866
@gnprice gnprice mentioned this issue Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-message list P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

msglist: Handle topic permalinks (/with/<id>) just as we do /near/ links chrisbobbe/zulip-mobile
1 participant
@gnprice