Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce some more require cycles. #3153

Closed
wants to merge 5 commits into from

Conversation

jainkuniya
Copy link
Member

No description provided.

@gnprice gnprice added the review label Nov 17, 2018
@borisyankov
Copy link
Contributor

Are these all reported as require cycles though? We don't need to go further than what is actually given as a warning.
Run the app and look at the console log. After we merged the previous PR there were just 3 outstanding require cycles that were in our code, and they seemed a little tricky (not much, just not straightforward)

@gnprice gnprice removed the review label Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants