Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build-run instructions in docs #4148

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Update build-run instructions in docs #4148

merged 3 commits into from
Jun 12, 2020

Commits on Jun 12, 2020

  1. docs/build-run: Add troubleshooting entry for Metro not running. 

    Regarding the app crash that can happen when
`react-native run-android` is executed without starting the
Metro bundler server.
    @agrawal-d @gnprice
    agrawal-d authored and gnprice committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    7e93817 View commit details
    Browse the repository at this point in the history

  2. docs/build-run: Sort new troubleshooting entry to right spot. 

    We have these broadly in the order you might run into them:
first in setting up the environment, then in building, then in
running.
    @gnprice
    gnprice committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    a4c838b View commit details
    Browse the repository at this point in the history

  3. docs/build-run: Make small edits to new troubleshooting entry. 

    Edits include:

* The error message doesn't appear on the terminal, but rather in a
  GUI in the app, and as a wrapped paragraph in sans-serif rather than
  as monospace.  (Also the wrapping here differs from the actual
  message.)  So use a plain quotation block rather than a code block.

* Fix the quoted error message slightly to match what's actually shown.

* Put a key phrase from the message in the heading.

* Write out the commands names in full, to help them be found by search.
    @gnprice
    gnprice committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    a1db664 View commit details
    Browse the repository at this point in the history