msg action sheet: Add 'Reply with mention' option. #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Jul 21, 2020
There was a problem hiding this comment.
Thanks, @agrawal-d!
I haven't looked at this super closely yet (though, thankfully, my testing prompted 8c55b4a! 🙂) , but I noticed a Flow error in messageActionSheet.js. I saw this after rebasing atop master, though, and I didn't run Flow before then—I suspect it's something Flow newly flags starting with the upgrade, which we did with the RN v0.60 -> v0.61 upgrade; this PR doesn't have the RN upgrade.
Would you mind rebasing and see if you also get a Flow error?
| @@ -212,4 +214,4 @@ | |||
| "🤒 Out sick": "🤒 Out sick", | |||
| "🌴 Vacationing": "🌴 Vacationing", | |||
| "🏠 Working remotely": "🏠 Working remotely" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nit: newline at end of file
Adds the reply with mention featrue, that populates the compose box message input with an @-mention, the topic input (if present) with the topic of the message and shows the keyboard. Fixes: zulip#3436
Yep, I got the Flow error. I've fixed it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the reply with mention featrue, that populates the compose box
message input with an @-mention, the topic input (if present) with
the topic of the message and shows the keyboard.
Fixes: #3436.