i18n: Remove a duplicate message key. #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P0 because this is an easy fix for a problem that's blocking a release. I guess I also don't know what consequences this duplication might have at runtime; I haven't yet tested. 🙂 |
I got the following error when I ran `tools/tx-sync`:
```
Step 3: Upload strings to translate...
+ tx --quiet push -s
tx ERROR: Error received from server: Duplicate string key ('Oops! Something went wrong\.') in line 247
tx ERROR: Could not upload source file. You can use --skip to ignore this error and continue the execution.
tx ERROR: Error received from server: Duplicate string key ('Oops! Something went wrong\.') in line 247
```
Looks like maybe a rebase error when I was working on zulip#4754. The
string was already added, in zulip#4829.
gnprice
force-pushed
the
pr-duplicate-i18n-message
branch
from
2f004af
to
71b7c2c
Compare
|
Looks good, thanks -- merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error when I ran
tools/tx-sync:Looks like maybe a rebase error when I was working on #4754. The
string was already added, in #4829.