Commits on Sep 10, 2021

1. reactUtils tests: Start testing useHasStayedTrueForMs. …

   This is our first use of `react-test-renderer`. It piggy-backs on
   our incorporation of Jest's "modern" fake-timer implementation in
   PRs zulip#4754 and zulip#4931. That was handy!
   
   I haven't yet found any test cases that fail with our
   implementation. (And I'd been hoping to, to debug an unexpected
   error!)
   
   But I did try pasting in an earlier iteration of the hook's
   implementation, from zulip#4940, that Greg had found bugs in by reading
   the code. Many of these tests failed on that buggy implementation,
   which is a good sign.
   
   Might as well keep these new tests, then, if they're not an
   unreasonable maintenance burden.

   

   chrisbobbe committed Sep 10, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for ec99f95
   • Browse repository at this point

   Copy the full SHA

   ec99f95 View commit details

   Browse the repository at this point in the history