dep types: Use TsFlower for expo-application and expo-screen-orientation

[chrisbobbe]

I'd like to do this on the way to #5441, upgrading to Expo SDK 44.

[gnprice]

Thanks @chrisbobbe! This looks good -- small comments below.

[gnprice]

Looks like there's still a file flow-typed/expo-screen-orientation_vx.x.x.js, so we should delete that.

[gnprice]

Would be good to mention that this doesn't describe all the quirky behavior of these TS enums (namely that it maps values to names as well as names to values.)

[gnprice]

Oh also: the references to ft-flow in eslint-ignore lines look like they depend on part of #5444 .

[chrisbobbe]

Thanks for the review! Revision pushed. I removed the ft-flow eslint-ignore lines; it seems tools/test lint doesn't cover the files in types/ anyway. (Not sure why, or maybe I'm missing some nuance there.)

[gnprice]

Thanks! Looks good; merging.

[chrisbobbe]

Thanks for the review!

[gnprice]

it seems tools/test lint doesn't cover the files in types/ anyway. (Not sure why, or maybe I'm missing some nuance there.)

Yeah, that's ultimately due to this bit:

# Intersect $files with the set of our JS files in src/.
#
# Prints a list of newline-terminated paths; either files, or
# directories meaning their whole subtrees.
files_js() {
    local file_pattern='^src/.*\.js$'

If we want to lint the type definitions, that could be accomplished by changing the lint case here to be like the prettier case:

        lint)
            run_lint $(files_js)
            ;;
        jest)
            run_jest
            ;;
        prettier)
            run_prettier $(files_js_jsflow)
            ;;

as files_js_jsflow is defined to apply to those too.

I'm not sure we do want lint on the type definitions, though, or at least the generated ones. When I open one of the longer files in types/@react-navigation/, it seems like there are a lot of lint errors that wouldn't be productive to try to resolve.