New compose box design #561
Conversation
|
Automated message from Dropbox CLA bot @kunall17, it looks like you've already signed the Dropbox CLA. Thanks! |
|
I think that part of the UI is one of the weak points of the web app, and is made much worse by the nature of mobile - I really didn't like the usability in the Android app. Typing is much harder, and way more error prone on mobile. Maybe we should just defer that to an in-person discussion with the other guys. It is such a weird concept, that if needed can be implemented better. |
|
Also, we will have another line under the ComposeText (that is hidden right now, will be shown soon), and we have this always pinned subhead in the messages, and when the keyboard is popped, if we add another line we have almost no space for the messages. What we definitely are missing is creating a new topic, but this concept needs work. |
Agreed, I'll make sure in the final version its based on the Names and not the emails
It often happens with me that I'm reading a stream and I need to message some other stream/person, it comes handy at that time. Moreover this UI does not flashes all the time that you'll be sending messages to this group/private which looked kinda awkward in native android, hence looks better. |
Yeah, this is something that we hard a lot from users; it's nice to be able to refer to some messages in a stream when PMing someone (e.g. to non-publicly point their attention at a public conversation). I think maybe what we should do is have the default compose state be a super light experience that just sends to the current narrow, but have a button that expands compose to a full version, where you can specify where you want to send to as a new messages, whether private or stream with a new or existing topic, etc. |
|
That makes sense; compared to the web version you are likely looking at just a few lines. Creating a new topic could be a custom case - it can be one of the buttons next to 'image', 'photo', 'video' and when clicked it might replace them with input temporarily. |
|
@borisyankov So I should move the bubble (mode switcher from the 1st image) button to the ComposeOptions row and let the ComposeText be un touched? |
|
@kunall17 so, we are splitting this task into two. First one, we start immediately. Next one will be 'soon but not next'. Immediately:
Not that soon:
|
|
Will start work from now, for the design modifications I pushed the mode changer button above With options On option change Without divider: Also what to go for, with or without long divider (Message box and compose options divider)? |
kunall17
force-pushed
the
patch-5
branch
2 times, most recently
from
f57dd56
to
ab32f11
Compare
|
@borisyankov Screencast: |
|
@borisyankov Updated the branch, lets keep these feature in this PR and other work in another PR Added night theme support as well |
|
Heads up @kunall17, we just merged some commits (latest: 8213182) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Heads up @kunall17, we just merged some commits (latest: 2578b4b) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Heads up @kunall17, we just merged some commits (latest: 8297fdc) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Heads up @kunall17, we just merged some commits (latest: d1bc5e9) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
kunall17
force-pushed
the
patch-5
branch
2 times, most recently
from
9dadad4
to
e36cde9
Compare
|
Updated :) |
kunall17
force-pushed
the
patch-5
branch
2 times, most recently
from
9d12d6f
to
9109b51
Compare
|
High-level changes needed: Will do a detailed code review when this is done. |
kunall17
force-pushed
the
patch-5
branch
2 times, most recently
from
fc4f97e
to
3b48206
Compare
|
Updated the PR, though it does not uses the |
There was a problem hiding this comment.
The way users will pick Streams or PM recipients will be completely different than current web app or native Android.
Do not include any mode changing or 'thinking ahead' code.
Also definitely hide the extra icons that were from before since I can not approve the PR with them visible.
When anyone looks at this PR, all the code should be about selecting a 'topic' and there should not be a hint even at what is coming up or what other PR did exist.
|
It looked fine on this emulator, can you specify more? |
|
Just forgot, It's Android 7.1 and i got this on personal device. |
|
@borisyankov @kunall17 We really need to get this merged soon. My work uploading images/files will be done after this is merged. |
| "Language": "Language" | ||
| "Language": "Language", | ||
| "Topic": "Topic", | ||
| "Type a message here": "Type a message here" |
There was a problem hiding this comment.
@kunall17 I think these should be added to all the other translations too?
There was a problem hiding this comment.
Good that you noticed, @saketkumar95
I added them for him with my last commit, so now it is OK.
|
Yeah, @kunall17 can you update the PR today? |
|
The historical PR, merged at last :D |
|
Haha, finally :) |
This is currently just for design suggestions and not for code review, after the correct design is finalized, I'll complete this!
First default screen
Stream
Private
