notif: For test-notification button, require FL 234+ instead of 217+ #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers with FL 217+ but not 234+ will send a payload to the bouncer that's missing realm_name, and the bouncer will error because it assumes realm_name is present. See API changelog: https://zulip.com/api/changelog So, require 234+. Like 217, 234 was released in Zulip Server 8.0, so the error dialog we give the user should still be accurate: Feature not available This feature is only available for organizations on Zulip Server 8.0+.
gnprice
force-pushed
the
pr-test-notif-234+
branch
from
9e2a799
to
838c58e
Compare
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers with FL 217+ but not 234+ will send a payload to the bouncer that's missing realm_name, and the bouncer will error because it assumes realm_name is present. See API changelog:
https://zulip.com/api/changelog
So, require 234+. Like 217, 234 was released in Zulip Server 8.0, so the error dialog we give the user should still be accurate: