Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: Fix breakage of LaTeX delimiters in quote-and-reply #5851

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

chrisbobbe
Copy link
Contributor

String.prototype.replace and String.prototype.replaceAll interpret certain sequences such as $$ within a string provided as the replacement argument. Because of this, LaTeX delimiters $$ were turning into $, and other sequences could duplicate part of the existing draft.

Avoid this interpretation by providing a function.

Fixes: #5849

@chrisbobbe chrisbobbe added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Apr 6, 2024
@chrisbobbe chrisbobbe requested a review from gnprice April 6, 2024 00:50
@gnprice
Copy link
Member

gnprice commented Apr 25, 2024

Thanks! Looks good; merging.

String.prototype.replace and String.prototype.replaceAll interpret
certain sequences such as $$ within a string provided as the
replacement argument. Because of this, LaTeX delimiters $$ were
turning into $, and other sequences could duplicate part of the
existing draft.

Avoid this interpretation by providing a function.

Fixes: zulip#5849
@gnprice gnprice merged commit 8140876 into zulip:main Apr 25, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-quote-and-reply-latex branch June 12, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote and reply does not quote LaTeX correctly
2 participants