Extracted auto complete pop up from ComposeText. #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainkuniya
force-pushed
the
issue-705-i
branch
2 times, most recently
from
54470c2
to
0d46610
Compare
|
Heads up @vishwesh3, we just merged some commits (latest: 06e6f07) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Don't show them between topic and message field. Show them above topic field.
- Change background color with theme. - List looks like they are part of ComposeBox (like messenger). - Use RawLabel for text in emoji row.
almost half is taken by keyboard and compose box and another 1/4th should be kept for nav bar, status bar and some part of message list.
|
@borisyankov Rebased branch 👍 |
|
Looks good. I thought to do something similar, so great that I don't need to anymore ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #705
