New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped notifications into one and show the notifications as a list #734

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jun 24, 2017

This is expanding notifications not complete yet.
Wanted some suggestions if this can be made better

Expanded:
screen shot 2017-06-24 at 10 44 03 am

Default view: (the latest message is shown here) What would be the most appropriate content text here?
screen shot 2017-06-24 at 10 45 42 am

@smarx

This comment has been minimized.

smarx commented Jun 24, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jun 24, 2017

Updated
screen shot 2017-06-24 at 11 44 01 pm

@kunall17 kunall17 changed the title from [WIP] Grouped notifications into one and show the notifications as a list to Grouped notifications into one and show the notifications as a list Jun 24, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jun 24, 2017

'New 4 messages' should be '4 new messages'.

If the message does not fit anyways, we should just say 'N new messages' without the 'from N conversations'.

Do we even want to group them though? How does it work in Slack & FB Messenger?

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jun 25, 2017

Without grouping right now we are replacing the old notifications, hence loosing content
Slack and whatsapp both group messages in a similar way

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jun 25, 2017

Fixed and added a commit to show the number of messages in the home screen
This is dependent on different launchers, library I used is popular and works well on my sony phone

screenshot_20170625-145406

@zulipbot

This comment has been minimized.

Member

zulipbot commented Jun 25, 2017

Heads up @kunall17, we just merged some commits (latest: 8898fd8) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jun 25, 2017

Looks good to merge. Please rebase.

kunall17 added some commits Jun 24, 2017

Group the notification into one showing all the notifications
Adds an action to clear all the notifications
@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jun 26, 2017

Updated

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jun 26, 2017

Great. Thanks.

@borisyankov borisyankov merged commit b88fc00 into zulip:master Jun 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 59.069%
Details

@zulipbot zulipbot removed the needs review label Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment