-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped notifications into one and show the notifications as a list #734
Conversation
Automated message from Dropbox CLA bot @kunall17, it looks like you've already signed the Dropbox CLA. Thanks! |
'New 4 messages' should be '4 new messages'. If the message does not fit anyways, we should just say 'N new messages' without the 'from N conversations'. Do we even want to group them though? How does it work in Slack & FB Messenger? |
Without grouping right now we are replacing the old notifications, hence loosing content |
Heads up @kunall17, we just merged some commits (latest: 8898fd8) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Looks good to merge. Please rebase. |
Adds an action to clear all the notifications
Updated |
Great. Thanks. |
This is expanding notifications not complete yet.
Wanted some suggestions if this can be made better
Expanded:
![screen shot 2017-06-24 at 10 44 03 am](https://user-images.githubusercontent.com/12700799/27505924-160f7982-58ca-11e7-84bf-df54271ebfe0.png)
Default view: (the latest message is shown here) What would be the most appropriate content text here?
![screen shot 2017-06-24 at 10 45 42 am](https://user-images.githubusercontent.com/12700799/27505940-53ebd5e8-58ca-11e7-8e63-cd219f910926.png)