bugfix: helper: Avoid always notifying as outside narrow for group PMs.

This commit fixes a bug that previously caused a "Message sent outside
current narrow." message in the footer in group pms (huddles) even when
on the right narrow. This happened because of the wrong separator being
used, ','. This has been changed to the relevant separator - ', '.

Test added.

tests/helper/test_helper.py

@@ -362,6 +362,16 @@ def test_display_error_if_present(mocker, response, footer_updated):
             False,
             id="all_private__pm__not_notified",
         ),
+        case(
+            {
+                "type": "private",
+                "to": ["foo@zulip.com", "bar@zulip.com"],
+                "content": "Hi",
+            },
+            [["pm_with", "foo@zulip.com, bar@zulip.com"]],
+            False,
+            id="group_private_conv__same_group_pm__not_notified",
+        ),
         case(
             {
                 "type": "private",

zulipterminal/helper.py

@@ -685,7 +685,7 @@ def notify_if_message_sent_outside_narrow(
         check_narrow_and_notify(stream_narrow, topic_narrow, controller)
     elif message["type"] == "private":
         pm_narrow = [["is", "private"]]
-        pm_with_narrow = [["pm_with", ",".join(message["to"])]]
+        pm_with_narrow = [["pm_with", ", ".join(message["to"])]]
         check_narrow_and_notify(pm_narrow, pm_with_narrow, controller)