Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't edit messages: "Time limit for editing the message body..." #1034

Closed
fredrikekre opened this issue May 14, 2021 · 4 comments · Fixed by #1035
Closed

Can't edit messages: "Time limit for editing the message body..." #1034

fredrikekre opened this issue May 14, 2021 · 4 comments · Fixed by #1035
Labels
area: message editing bug Something isn't working missing feature: user A missing feature for all users, present in another Zulip client
Milestone
0.7.0

Comments

@fredrikekre
Copy link
Contributor

I am running zulip-term from docker (https://github.com/zulip/zulip-terminal/blob/main/docker/Dockerfile.buster) and I am not able to edit messages I have sent, even if it is directly after. I see the error

Time limit for editing the message body exceeded

but I can go to the browser client and edit the message just fine.

Worth noting also that https://julialang.zulipchat.com, where I noticed this, doesn't enforce any time limit on edits.

cc @MasonProtter
@prah23
Copy link
Member

prah23 commented May 14, 2021

Thanks for taking the time to report this, @fredrikekre!

Worth noting also that https://julialang.zulipchat.com, where I noticed this, doesn't enforce any time limit on edits.

This points us in the right direction.

@zulipbot claim

@zulipbot
Copy link
Member

Hello @prah23!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@neiljp neiljp added area: message editing missing feature: user A missing feature for all users, present in another Zulip client labels May 15, 2021
prah23 added a commit to prah23/zulip-terminal that referenced this issue May 15, 2021
@prah23
bugfix: boxes: Allow message body editing when limit doesn't exist.
d29b982 
This commit fixes a bug that doesn't let the users edit the message body
when the `realm_message_content_edit_limit_seconds` sent by the server
is 0 for a realm. Prior to this commit, this configuration of 0 was
treated as a complete restriction against message body editing, while
the configuration actually signified no limit in message body editing.

Fixes zulip#1034.
prah23 added a commit to prah23/zulip-terminal that referenced this issue May 15, 2021
@prah23
bugfix: boxes: Allow message body editing when limit doesn't exist.
df0ca72 
This commit fixes a bug that doesn't let the users edit the message body
when the `realm_message_content_edit_limit_seconds` sent by the server
is 0 for a realm. Prior to this commit, this configuration of 0 was
treated as a complete restriction against message body editing, while
the configuration actually signified no limit in message body editing.

Fixes zulip#1034.
@prah23 prah23 mentioned this issue May 15, 2021
Merged
@neiljp neiljp closed this as completed in e51c15c May 15, 2021
@neiljp neiljp added this to the Next Release milestone May 15, 2021
@neiljp
Copy link
Collaborator

neiljp commented May 15, 2021

@fredrikekre A fix should be in main now; thanks to @prah23 🎉

@fredrikekre
Copy link
Contributor Author

Thanks

@neiljp neiljp added the bug Something isn't working label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: message editing bug Something isn't working missing feature: user A missing feature for all users, present in another Zulip client
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

bugfix: boxes: Allow message body editing when limit doesn't exist. prah23/zulip-terminal
4 participants
@neiljp @fredrikekre @zulipbot @prah23