bugfix: boxes: Allow message body editing when limit doesn't exist. #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: L
This commit fixes a bug that doesn't let users edit the message body when the `realm_message_content_edit_limit_seconds` sent by the server is 0 for a realm. Prior to this commit, this configuration of 0 was treated as a complete restriction against message body editing, while the configuration actually signified no limit in message body editing. Fixes zulip#1034.
neiljp
force-pushed
the
msg_edit_restrictions
branch
from
df0ca72
to
e51c15c
Compare
|
@prah23 Thanks for the quick fix! 👍 I reordered the test parameters to keep the expected value at the end and have just merged 🎉 I checked the server tests and the zero value meaning is indicated there; as per my message in the stream, if there is not API documentation of this special value then I'd suggest we add an issue or PR for that, or discuss on czo. |
|
Thanks for merging it, @neiljp! I think an issue/PR would be prompt as well, as the documentation seems missing for this. I've also responded on CZO to discuss further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a configuration of 0 for
realm_message_content_edit_limit_secondsis treated as a complete restriction against message body editing, while
the configuration actually signifies no limit in message body editing.
This PR adds a commit that fixes the bug that doesn't let the users
edit the message body when the configuration sent by the server is 0
for a realm.
Fixes #1034.