Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests failing on WSL systems. #1511

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix tests failing on WSL systems. #1511

wants to merge 3 commits into from

Commits on Sep 30, 2024

  1. refactor: helper: Fix WSL normalized_file_paths related tests. 

    Addressed issues with file path separators `\\` specific to WSL
environments.
    @rsashank
    rsashank committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d35068f View commit details
    Browse the repository at this point in the history

  2. platform_code: Add process_media_tool function. 

    The process_media_tool function determines and returns the media tool
used based on the OS.
    @rsashank
    rsashank committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3b52fcd View commit details
    Browse the repository at this point in the history

  3. bugfix: tests: Fix WSL GUI exit status related tests. 

    WSL always returns a non-zero exit code. The `successful_GUI_return_code()`
function has been refactored to directly compare exit statuses and return
"success" or "failure" accordingly.

Fix open_media test to validate both the tool and the error code across
various platforms.

Refactor process_media to shift platform dependent code to platform_code.py.
    @rsashank
    rsashank committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fe589a5 View commit details
    Browse the repository at this point in the history