Skip to content

Commit

Permalink
linkifier settings: Remove loading indicator.
Browse files Browse the repository at this point in the history
There is no element on the settings page with
id="admin_page_filters_loading_indicator", so
the indicator doesn't appear. And even if we make
a div for an indicator, it would be hardly visible,
because we don't call the server to fetch linkifiers
in this page, and there generally won't be too many
linkifiers to render.
  • Loading branch information
abhijeetbodas2001 authored and timabbott committed Mar 15, 2021
1 parent 0acfbc3 commit 2ea330b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions static/js/settings_linkifiers.js
Expand Up @@ -4,7 +4,6 @@ import render_admin_linkifier_list from "../templates/admin_linkifier_list.hbs";

import * as channel from "./channel";
import * as ListWidget from "./list_widget";
import * as loading from "./loading";
import * as ui from "./ui";
import * as ui_report from "./ui_report";

Expand Down Expand Up @@ -76,8 +75,6 @@ export function populate_linkifiers(linkifiers_data) {
},
simplebar_container: $("#linkifier-settings .progressive-table-wrapper"),
});

loading.destroy_indicator($("#admin_page_filters_loading_indicator"));
}

export function set_up() {
Expand All @@ -88,9 +85,6 @@ export function set_up() {
export function build_page() {
meta.loaded = true;

// create loading indicators
loading.make_indicator($("#admin_page_filters_loading_indicator"));

// Populate linkifiers table
populate_linkifiers(page_params.realm_filters);

Expand Down

0 comments on commit 2ea330b

Please sign in to comment.