Skip to content

Commit

Permalink
capitalization: Add 'I understand' to the IGNORED_PHRASES list.
Browse files Browse the repository at this point in the history
String 'Here are a few messages I understand:'(next commit) was failing
./tools/check-capitalization check because of the capital I. I added
'I understand' to the IGNORED_PHRASES list in tools/lib/capitalization.py.

Adding "I" was working as well but didn't seem to me as a very great fix.
Strangely enough, adding " I " to the list made the test fail again
(With a lot of failed strings this time) as mentioned in the following
CZO thread.

Relevent CZO chat -
https://chat.zulip.org/#narrow/stream/49-development-help/topic/capitalization.20confusion.2E
  • Loading branch information
raghupalash authored and timabbott committed Dec 1, 2021
1 parent 54d037f commit 67f35d9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/lib/capitalization.py
Expand Up @@ -72,6 +72,7 @@
r".zuliprc",
r"__\w+\.\w+__",
# Things using "I"
r"I understand",
r"I say",
r"I want",
r"I'm",
Expand Down

0 comments on commit 67f35d9

Please sign in to comment.