Skip to content

Commit

Permalink
settings/muted-topics: Fix unnecessary use of stopImmediatePropogation.
Browse files Browse the repository at this point in the history
We do not have any other click handlers for the
`settings-unmute-topic` class, so `stopPropogation`
should be sufficient.
  • Loading branch information
abhijeetbodas2001 authored and timabbott committed Apr 28, 2021
1 parent 05f2ebb commit eff16c9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion frontend_tests/node_tests/settings_muted_topics.js
Expand Up @@ -48,7 +48,7 @@ run_test("settings", () => {
assert.equal(typeof topic_click_handler, "function");

const event = {
stopImmediatePropagation: noop,
stopPropagation: noop,
};

const topic_fake_this = $.create("fake.settings-unmute-topic");
Expand Down
2 changes: 1 addition & 1 deletion static/js/settings_muted_topics.js
Expand Up @@ -11,7 +11,7 @@ export function set_up() {
const stream_id = Number.parseInt($row.attr("data-stream-id"), 10);
const topic = $row.attr("data-topic");

e.stopImmediatePropagation();
e.stopPropagation();

muting_ui.unmute_topic(stream_id, topic);
$row.remove();
Expand Down

0 comments on commit eff16c9

Please sign in to comment.