Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/apps Page Images are slow to load #10104

Open
armaanahluwalia opened this issue Jul 29, 2018 · 14 comments · Fixed by #10133
Open

/apps Page Images are slow to load #10104

armaanahluwalia opened this issue Jul 29, 2018 · 14 comments · Fixed by #10133

Comments

@armaanahluwalia
Copy link
Contributor

There are a couple of bugs on the /apps page of the website.

  1. When we click any of the different platforms except for the default ( macOS ), the images are slow to load and take around a half second after clicking to actually load the correct image. Specifically the android image for some reason takes longer and seems to load another image before loading the correct one.

  2. The buttons do not have an enabled states. Its a bit confusing to know that this is indeed a clickable tab menu from UX perspective. The buttons should have enabled states.

@akashnimare
Copy link
Member

akashnimare commented Jul 30, 2018

The buttons do not have an enabled states. Its a bit confusing to know that this is indeed a clickable tab menu from UX perspective. The buttons should have enabled states.

Agreed on this. We could use the same button styling which we're using on /plans page -

(^^ this looks more polished I think)
cc @rishig.

@rishig
Copy link
Member

rishig commented Jul 30, 2018

good catch!

@timabbott
Copy link
Sponsor Member

@akashnimare sounds good re: buttons. Want to submit a quick PR for that, and then we can look at redoing the app screenshots as a follow-up (that probably involves more discussion).

@akashnimare
Copy link
Member

Cool, will submit the PR for the same. Rishi and I have almost finished the work on the screenshots, it just needs some finishing.

akashnimare added a commit to akashnimare/zulip that referenced this issue Jul 31, 2018
This PR updates the styling of download button so
that it matches with the other buttons on portico pages.

Partially fixes zulip#10104.
akashnimare added a commit to akashnimare/zulip that referenced this issue Jul 31, 2018
This PR updates the styling of download button so
that it matches with the other buttons on portico pages.

Partially fixes zulip#10104.
timabbott pushed a commit that referenced this issue Jul 31, 2018
This PR updates the styling of download button so
that it matches with the other buttons on portico pages.

Partially fixes #10104.
@armaanahluwalia
Copy link
Contributor Author

@timabbott I think this was incorrectly closed. I was actually talking about the tab menu below the featured app image splash. See attached screenshot.

screen shot 2018-08-01 at 3 30 11 am

@armaanahluwalia
Copy link
Contributor Author

Those don't have enabled states so its difficult to even realized they're clickable. The other issue of the images taking too long to load was also not addressed ( Not sure if another issue was opened for that ).

@timabbott
Copy link
Sponsor Member

Yeah, I think this is a classic case of #10133 having been mis-tagged as fixing this issue; its commit message should have said "Fixes part of #10104". @akashnimare FYI, reopening.

@timabbott timabbott reopened this Jul 31, 2018
@akashnimare
Copy link
Member

@armaanahluwalia It's always a good idea to post the screenshots etc in the issue description to make the issue crystal clear. This is what I always do to avoid any confusions :) If you go on the /apps page there is only one button which is the download button. That button didn't have the enabled state so the changes I have made are still relevant.

I was actually talking about the tab menu below the featured app image splash. See attached screenshot.

Did you notice the background and opacity change when you hover over the OS icons?

Normal state:

image


On Hover:

image

The other issue of the images taking too long to load was also not addressed

We are loading the images using the JS so depending on your internet it may take few secs to load but I agree that we could better here.

its commit message should have said "Fixes part of #10104".

@timabbott my bad, I was bit confused about what to use in the commit message. I checked old commit messages and found out that others have used things like "Partially fixes #issue" to indicate that the issue only fixes a part and not the full issue hense I have used the same thing in commit message.

This PR updates the styling of download button so
that it matches with the other buttons on portico pages.
Partially fixes #10104.

@armaanahluwalia
Copy link
Contributor Author

@akashnimare Thanks for the feedback. I'll try to communicate better going forward. I actually did notice the hover state but I'm referring specifically to the fact that the hover state is not 'enabled' by default on the first option. This is pretty standard when designing any kind of buttons. The one thats selected has an 'enabled' state different from their default 'unselected' state. This is especially useful in a tab menu that blends into the page as it does here so people know that they can click on it without having to move their mouse and happen to hover over the icons to discover this.

Regarding the images I think we have 2 options here –

  1. Preload all images onto the page using a preloader ( many available online )
  2. Optimize images to load faster

@armaanahluwalia
Copy link
Contributor Author

armaanahluwalia commented Aug 1, 2018

We also haven't addressed the bug that there is a flash of another image ( or different sized image ) before loading the android tab. So when you click the android button, you see the image change and THEN load the android image.

EDIT: I just tested and this is not limited to android. It happens and gets worse when you click around the other buttons in random order.

@armaanahluwalia
Copy link
Contributor Author

Image Bug

@akashnimare
Copy link
Member

So if a user is on /apps/mac page, the macOS tab icon should be enabled, right (same as what we see when you hover on the icon)?

@armaanahluwalia
Copy link
Contributor Author

I would say yes. Since we don't have a design for an enabled state we could use the hover state styles. Better than nothing IMO.

@zulipbot
Copy link
Member

zulipbot commented Aug 2, 2018

Hello @zulip/server-misc members, this issue was labeled with the "area: portico" label, so you may want to check it out!

ljagielski2 pushed a commit to ljagielski2/zulip that referenced this issue Aug 18, 2018
This PR updates the styling of download button so
that it matches with the other buttons on portico pages.

Partially fixes zulip#10104.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants