Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack import: Record which user uploaded custom emoji in import data #10268

Open
timabbott opened this issue Aug 10, 2018 · 1 comment
Open

Comments

@timabbott
Copy link
Sponsor Member

We currently have a few hacks in our data import code for custom emoji to not assume that the user_profile_id field is set (and set author to None), because our Slack export tool doesn't have the data. Since Slack does show who uploaded custom emoji in their UI, it seems possible the data is available; we should try to get it and clean up the codebase.

@zulipbot
Copy link
Member

Hello @zulip/server-misc members, this issue was labeled with the "area: export/import" label, so you may want to check it out!

timabbott added a commit that referenced this issue Aug 10, 2018
The s3 import code path made a hard assumption about `user_profile_id`
being set (we'd already fixed this in the local uploads code path).

Ideally, it should be, and I've opened #10268 for fixing that, but for
now this is how it needs to work.
ljagielski2 pushed a commit to ljagielski2/zulip that referenced this issue Aug 18, 2018
The s3 import code path made a hard assumption about `user_profile_id`
being set (we'd already fixed this in the local uploads code path).

Ideally, it should be, and I've opened zulip#10268 for fixing that, but for
now this is how it needs to work.
@Gittenburg Gittenburg added new feature A proposed new feature for the product and removed new feature A proposed new feature for the product labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants