-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User profile modal closes on click. #10500
Comments
@zulipbot add "bug" "area: general UI" |
showell
pushed a commit
to showell/zulip
that referenced
this issue
Sep 13, 2018
We have a body-level click handler that closes all modals if you click outside a modal. This code is a bit brittle, because we need to first check that the element we clicked is not in a modal, and our markup there isn't entirely consistent. This is a quick fix that just adds `#user-profile-modal` as one of the selectors to look for. Fixes zulip#10500
showell
pushed a commit
that referenced
this issue
Sep 14, 2018
We have a body-level click handler that closes all modals if you click outside a modal. This code is a bit brittle, because we need to first check that the element we clicked is not in a modal, and our markup there isn't entirely consistent. This is a quick fix that just adds `#user-profile-modal` as one of the selectors to look for. Fixes #10500
dipu989
pushed a commit
to dipu989/zulip
that referenced
this issue
Sep 23, 2018
We have a body-level click handler that closes all modals if you click outside a modal. This code is a bit brittle, because we need to first check that the element we clicked is not in a modal, and our markup there isn't entirely consistent. This is a quick fix that just adds `#user-profile-modal` as one of the selectors to look for. Fixes zulip#10500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Screenshot:
With this, it isn't possible to select or copy text from the modal UI.
The text was updated successfully, but these errors were encountered: