Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend our auto-linkification algorithm to linkify custom protocols #10797

Open
timabbott opened this issue Nov 8, 2018 · 6 comments
Open

Extend our auto-linkification algorithm to linkify custom protocols #10797

timabbott opened this issue Nov 8, 2018 · 6 comments
Labels
area: markdown new feature A proposed new feature for the product priority: high

Comments

@timabbott
Copy link
Sponsor Member

We'd like to extend Zulip to allow linkifying a wider range of links, including those on custom protocols (This will probably involve removing the ENABLE_FILE_LINKS setting).

https://chat.zulip.org/#narrow/stream/49-development-help/subject/bugdown/near/466939 has relevant context and some test cases.

@aero31aero this might be a good project for you.
@zulipbot
Copy link
Member

zulipbot commented Nov 8, 2018

Hello @zulip/server-markdown members, this issue was labeled with the "area: markdown" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member Author

I can imagine starting out with 2 phases: First, writing a set of test cases for what we want to behave differently, and then working on the markdown processor implementation.

@aero31aero
Copy link
Member

@zulipbot claim

@aero31aero aero31aero mentioned this issue Nov 13, 2018
Closed
@zulipbot
Copy link
Member

zulipbot commented Nov 21, 2018 •
edited

Hello @aero31aero, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@aero31aero aero31aero mentioned this issue Aug 26, 2019
Open
2 tasks
aero31aero added a commit to aero31aero/zulip that referenced this issue Aug 29, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
c1f16bc 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Aug 29, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
1bf1d69 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Aug 29, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
71ac7c5 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Sep 16, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
dcc42ed 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Sep 17, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
5ee1518 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
timabbott pushed a commit to aero31aero/zulip that referenced this issue Oct 15, 2019
@aero31aero @timabbott
markdown: Autolink all url schemes in angle brackets.
47b71aa 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Nov 21, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
6f6b98f 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Dec 14, 2019
@aero31aero
markdown: Autolink all url schemes in angle brackets.
ca85b51 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Feb 5, 2020
@aero31aero
markdown: Autolink all url schemes in angle brackets.
9dcfa41 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Mar 18, 2020
@aero31aero
markdown: Autolink all url schemes in angle brackets.
3929dfc 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue Apr 20, 2020
@aero31aero
markdown: Autolink all url schemes in angle brackets.
b1769d2 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
aero31aero added a commit to aero31aero/zulip that referenced this issue May 12, 2020
@aero31aero
markdown: Autolink all url schemes in angle brackets.
5e54ba2 
This allows us to create links like `<irc://example.com>`.

We update our link regex to match the valid url scheme format and then
check in AutoLink processor if our link is bracketed. This information
is used by sanitize_url to determine if we're going to render the link.

Fixes zulip#10797, fixes zulip#10450.
@Gittenburg Gittenburg added the new feature A proposed new feature for the product label Jul 10, 2020
@Gittenburg Gittenburg mentioned this issue Jul 10, 2020
Closed
@timabbott
Copy link
Sponsor Member Author

Just adding a note that we removed ENABLE_FILE_LINKS / file:// support because browsers removed support that URL scheme in links for security reasons.

We currently allow the URL schemes documented here: https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme.

@timabbott timabbott mentioned this issue Apr 23, 2022
Open
@Zio3D
Copy link

Zio3D commented Apr 30, 2024

Is it normal for the "ENABLE_FILE_LINKS = False" statement to still be found in various configuration files even if its functionality has been removed?
For example I find it in "zproject/default_settings.py", "zproject/prod_settings_template.py", etc.

Finding 'ENABLE_FILE_LINKS' in "/etc/zulip/settings.py" I tried to set it to 'True' but then I read in your previous post that 'ENABLE_FILE_LINKS' is no longer handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: markdown new feature A proposed new feature for the product priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timabbott @aero31aero @zulipbot @Zio3D @Gittenburg