Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebars only support arrow keys, not pgup/pgdn/home/end #10842

Open
nagisa opened this issue Nov 15, 2018 · 6 comments
Open

Sidebars only support arrow keys, not pgup/pgdn/home/end #10842

nagisa opened this issue Nov 15, 2018 · 6 comments
Labels
area: keyboard UI area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers

Comments

@nagisa
Copy link

nagisa commented Nov 15, 2018

Scrolling in the stream list seems to be manually implemented and does not appear to honour the system-wide scrolling behaviour. For example, scrolling appears to be much slower than the rest of the content elsewhere on the system, Home/PgUp/PgDn/End do not work and similar issues.

If scrolling behaviour is overriden, care should be taken to ensure that it is behaviourally consistent with the native scrolling.

@timabbott
Copy link
Sponsor Member

@nagisa by stream list, do you mean the "stream settings" page or the left sidebar?

@nagisa
Copy link
Author

nagisa commented Nov 16, 2018 via email

@zulipbot
Copy link
Member

zulipbot commented Jan 5, 2019

Hello @zulip/server-sidebars members, this issue was labeled with the "area: left-sidebar" label, so you may want to check it out!

@architkshk
Copy link
Collaborator

@zulipbot claim

@showell
Copy link
Contributor

showell commented Jan 7, 2019

Before anybody works on this, please discuss on chat. We have "q" and "w" hotkeys that allow you to navigate sidebars with arrow keys. Adding support for home, end, etc. would be a bit nontrivial due to complexities in the sidebars (pinning in left sidebar, rendering optimizations in right sidebar), so this is a bad issue for somebody without much experience in the Zulip codebase.

I'm not able to reproduce these keys actually messing with the message feed, which would increase the priority of the issue.

@showell showell changed the title Scrolling in the stream list does not honour the system-wide scroll behaviour Sidebars only support arrow keys, not pgup/pgdn/home/end Jan 7, 2019
@architkshk
Copy link
Collaborator

@zulipbot abandon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: keyboard UI area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers
Projects
None yet
Development

No branches or pull requests

8 participants