Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an icon font for Manage Stream checkmarks. #10918

Open
showell opened this issue Nov 29, 2018 · 1 comment
Open

Create an icon font for Manage Stream checkmarks. #10918

showell opened this issue Nov 29, 2018 · 1 comment

Comments

@showell
Copy link
Contributor

showell commented Nov 29, 2018

We repeat the same SVG to draw checkmarks for streams in our "Manage Streams" feature. This is expensive for template rendering.

I attempted the naive fix in #10915, but browsers don't apply CSS to external SVG elements.

All the checkmarks in Manage Streams have the same shape, and same underlying SVG, but we use CSS to set the "fill" color and do things upon hover, etc.

@synicalsyntax suggested another approach here:

https://chat.zulip.org/#narrow/stream/6-frontend/subject/svg.20checkmarks/near/666289

You can use #7281 as inspiration.

@zulipbot
Copy link
Member

Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out!

synicalsyntax added a commit to synicalsyntax/zulip that referenced this issue Jan 22, 2019
synicalsyntax added a commit to synicalsyntax/zulip that referenced this issue Jan 31, 2019
synicalsyntax added a commit to synicalsyntax/zulip that referenced this issue Feb 18, 2019
synicalsyntax added a commit to synicalsyntax/zulip that referenced this issue Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants