Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portico: Fix a few minor things on /hello. #12853

Closed
3 of 4 tasks
rishig opened this issue Jul 22, 2019 · 20 comments
Closed
3 of 4 tasks

portico: Fix a few minor things on /hello. #12853

rishig opened this issue Jul 22, 2019 · 20 comments
Labels
area: portico help wanted

Comments

@rishig
Copy link
Member

rishig commented Jul 22, 2019 •
edited by timabbott

A few things I noticed

  • The gradient is broken:
    image

There should be no white triangle between the green and the gradient

  • There should be some on-hover behavior for the big tour card. Clicking anywhere on the card opens the tour, but it's not visually apparent that that is the case. Also possibly some on-hover behavior for the "Take the tour" button.

  • There should be some on-hover behavior for the app icons, which are clickable

  • "Atlassian migration guide" should be underlined on hover, similar to other links
@zulipbot
Copy link
Member

Hello @zulip/server-misc members, this issue was labeled with the "area: portico" label, so you may want to check it out!

@rishig rishig mentioned this issue Jul 22, 2019
Closed
@timabbott
Copy link
Sponsor Member

@alexandraciobica @synicalsyntax FYI.

@clarammdantas
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Aug 4, 2019 •
edited

Hello @clarammdantas, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@victorphoenix3
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @victorphoenix3, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@alexandraciobica
Copy link
Collaborator

@zulipbot claim

@alexandraciobica alexandraciobica mentioned this issue Aug 20, 2019
Closed
alexandraciobica added a commit to alexandraciobica/zulip that referenced this issue Aug 20, 2019
@alexandraciobica
portico: Add hover styling to Atlassian migration guide on /hello.
5c27199 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes: zulip#12853.
alexandraciobica added a commit to alexandraciobica/zulip that referenced this issue Aug 21, 2019
@alexandraciobica
portico: Add hover styling to Atlassian migration guide on /hello.
9de058f 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes: zulip#12853.
@zulipbot
Copy link
Member

zulipbot commented Sep 2, 2019 •
edited

Hello @alexandraciobica, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@KlebersonCanuto
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @KlebersonCanuto! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@KlebersonCanuto KlebersonCanuto mentioned this issue Sep 17, 2019
Closed
timabbott pushed a commit that referenced this issue Sep 17, 2019
@alexandraciobica @timabbott
portico: Add hover styling to Atlassian migration guide on /hello.
8828ef7 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes part of #12853.
@KlebersonCanuto KlebersonCanuto mentioned this issue Sep 18, 2019
Closed
@zulipbot
Copy link
Member

zulipbot commented Sep 27, 2019 •
edited

Hello @KlebersonCanuto, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

matheuscmelo pushed a commit to matheuscmelo/zulip that referenced this issue Sep 28, 2019
@alexandraciobica @matheuscmelo
portico: Add hover styling to Atlassian migration guide on /hello.
13722b9 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes part of zulip#12853.
evo42 pushed a commit to evo42/zulip that referenced this issue Oct 30, 2019
@alexandraciobica
portico: Add hover styling to Atlassian migration guide on /hello.
fa626f1 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes part of zulip#12853.
YashRE42 pushed a commit to YashRE42/zulip that referenced this issue Dec 12, 2019
@alexandraciobica
portico: Add hover styling to Atlassian migration guide on /hello.
e609043 
I changed the element to be  a `p` instead of `div` because the styling
for `a`s inside paragraphs is already there and the element should
anyway be a paragraph.

Fixes part of zulip#12853.
@wryonik
Copy link
Collaborator

wryonik commented Dec 29, 2019

@rishig is 2nd part of this issue still available? If yes, I want to know, is any hover effect previously decided for this or I can implement any random hover effect?

@timabbott
Copy link
Sponsor Member

Yes, it is. We don't have a specific hover behavior in mind, but you should do something that feels consistent with the design for the rest of the landing pages part of the site.

wryonik added a commit to wryonik/zulip that referenced this issue Jan 5, 2020
@wryonik
portico: Add on hover effect on tour card
46eeb7c 
Add box-shadow on tour card which appears on hovering over tour card.

Fixes: zulip#12853
@wryonik wryonik mentioned this issue Jan 5, 2020
Closed
@wryonik
Copy link
Collaborator

wryonik commented Jan 5, 2020 •
edited

@timabbott I have added a box-shadow to tour card for now as I have seen two effects on that page i.e., box-shadow and border. Border look somewhat weird on it

@wryonik wryonik mentioned this issue Jan 27, 2020
Closed
wryonik added a commit to wryonik/zulip that referenced this issue Jan 27, 2020
@wryonik
portico: Add on hover effect on tour card
b70df85 
Change mouse pointer and add box-shadow on tour card which appears on hovering over tour card.

Fixes: zulip#12853
wryonik added a commit to wryonik/zulip that referenced this issue Mar 26, 2020
@wryonik
portico: Add on hover effect on tour card.
73e9dea 
Change mouse pointer and add box-shadow on tour card which appears on hovering over tour card.

Fixes: zulip#12853
wryonik added a commit to wryonik/zulip that referenced this issue Mar 26, 2020
@wryonik
portico: Add on hover effect on tour card.
e5575f5 
Clicking anywhere on the tour card opens the tour, but it's not
visually apparent. This commit adds box-shadow and changes the mouse
pointer as an on-hover behavior.

Fixes zulip#12853
wryonik added a commit to wryonik/zulip that referenced this issue Mar 29, 2020
@wryonik
portico: Add on hover effect on tour card.
08951a0 
Clicking anywhere on the tour card opens the tour, but it's not
visually apparent. This commit adds box-shadow and changes the mouse
pointer as an on-hover behavior.

Fixes zulip#12853
@KarishmaVanwari
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @KarishmaVanwari, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@KarishmaVanwari
Copy link
Collaborator

@zulipbot claim

@KarishmaVanwari KarishmaVanwari mentioned this issue Jan 21, 2022
Closed
@KarishmaVanwari
Copy link
Collaborator

@rishig @timabbott I have created a PR for fixing task 2. Please have a look!

@zulipbot
Copy link
Member

zulipbot commented Jun 19, 2022 •
edited

@KarishmaVanwari You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@timabbott
Copy link
Sponsor Member

Closing as /hello is being rewritten in #24301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: portico help wanted
Projects
None yet
Milestone
No milestone
9 participants
@rishig @timabbott @clarammdantas @alexandraciobica @zulipbot @KlebersonCanuto @wryonik @victorphoenix3 @KarishmaVanwari